Dmitry Torokhov wrote: > Hi, > > On Fri, Jun 06, 2008 at 12:27:10AM +0200, Pau Oliva Fora wrote: >> From: Pau Oliva Fora <pau at eslack.org> >> >> Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer. >> >> Signed-off-by: Pau Oliva Fora <pau at eslack.org> >> > > The input piece looks good, however it seens that the input is the > only functionality that this driver exports so I don't see any reason > to make input device registration optional. Or are you planning on > adding more functions to it? > I wasn't planning on adding more functions, I posted it so that ?ric can have a look at the i2c part and integrate it in his driver. Pau Oliva