Hi Jean, On Wednesday 28 May 2008 17:39, Jean Delvare wrote: > Drop the reset parameter of the w83627hf driver. It seems it wasn't > that useful. It was dropped from the Linux 2.4 version of this driver > back in July 2004. > > The only users who have reported that they were still using this > parameter, needed it to switch the chip from automatic fan speed > control back to manual mode. Now that the driver creates pwmN_enable > sysfs files, users will be able to use these files instead, which is > way less agressive. > > Signed-off-by: Jean Delvare <khali at linux-fr.org> > --- > Note: this goes on top of Dominik Geyer's patch: > http://lists.lm-sensors.org/pipermail/lm-sensors/2008-May/023189.html > > Dominik, would you be so kind to review, test and ack this patch? > Thanks. The patch looks fine to me and applied successfully (with hunk offsets of -1 lines in file w83627hf.c). If there are only users who needed this quirk for switching PWM to manual mode, then I think it is safe to drop this code now. I did a short test on a W83697HF and it is working as expected. Acked-by: Dominik Geyer <dominik.geyer at gmx.de> -- Dominik Geyer
