Hi all: * Darrick J. Wong <djwong at us.ibm.com> [2008-04-28 10:33:36 -0700]: > On Sat, Apr 26, 2008 at 04:34:26PM +0200, Jean Delvare wrote: > > data->max_duty_at_overheat is not updated in adt7473_update_device, > > so it might be used before it is initialized (if the user reads from > > sysfs file max_duty_at_crit before writing to it.) > > > > Signed-off-by: Jean Delvare <khali at linux-fr.org> > > Cc: Darrick J. Wong <djwong at us.ibm.com> > > Thanks for catching this. Looks/compiles/seems to run ok, so: > Acked-by: Darrick J. Wong <djwong at us.ibm.com> > > As for !! vs (?:), I don't have any particular preference. Applied to hwmon-2.6.git/testing, thanks. -- Mark M. Hoffman mhoffman at lightlink.com
