Hi Jean: * Jean Delvare <khali at linux-fr.org> [2008-04-03 10:40:39 +0200]: > Function RANGE_TO_REG() is broken. For a requested range of 2000 (2 > degrees C), it will return an index value of 15, i.e. 80.0 degrees C, > instead of the expected index value of 0. All other values are handled > properly, just 2000 isn't. > > The bug was introduced back in November 2004 by this patch: > http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commit;h=1c28d80f1992240373099d863e4996cdd5d646d0 > > While this can be fixed easily with the current code, I'd rather > rewrite the whole function in a way which is more obviously correct. > > Signed-off-by: Jean Delvare <khali at linux-fr.org> > Cc: Justin Thiessen <jthiessen at penguincomputing.com> > --- > drivers/hwmon/lm85.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) Applied to hwmon-2.6.git/testing, thanks. -- Mark M. Hoffman mhoffman at lightlink.com
