On Tue, 6 May 2008 17:36:07 -0700, Andrew Morton wrote: > A checkpatch version which you might not have says > > WARNING: consider using strict_strtol in preference to simple_strtol > #1015: FILE: drivers/hwmon/ibmaem.c:918: > + int temp = simple_strtol(buf, NULL, 10); \ > > total: 0 errors, 1 warnings, 1221 lines checked > > because the code as you have it will accept input of the form "12foo". > strict_strtol() will error on that. As a side note, I really wonder why this new function wasn't named just strtol(), especially if the general idea is to get rid of the "simple" variant after some time. -- Jean Delvare