[PATCH 3/3] hwmon (dme1737): add support for SCH5027

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 27 Apr 2008 12:31:54 -0700, Juerg Haefliger wrote:
> On Sun, Apr 27, 2008 at 12:25 PM, Jean Delvare <khali at linux-fr.org> wrote:
> > On Sun, 27 Apr 2008 12:18:51 -0700, Juerg Haefliger wrote:
> >  > The sch5027 has only 3 VID inputs VID3-5. Bits0-2 of the VID register
> >  > are reserved.
> >
> >  This doesn't make much sense. 3 high VID bits without the corresponding
> >  3 low VID bits is pretty useless. I'm really curious what the designer
> >  had in mind... Anyway, what you have now doesn't add any value and
> >  could even be confusing. I'd rather not expose any VID value at all for
> >  the SCH5027 - my random guess is that these pins won't be wired in
> >  practice anyway.
> 
> So you're saying I should remove the vid & vrm sysfs attributes for this chip?

Yes, this is what I'm suggesting.

-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux