On Sun, 17 Feb 2008 15:02:50 -0500, Mark M. Hoffman wrote:
> * Darrick J. Wong <djwong at us.ibm.com> [2007-12-19 15:14:38 -0800]:
> > +static int adt7473_attach_adapter(struct i2c_adapter *adapter)
> > +{
> > + /*
> > + * Some NVIDIA cards have an adt7473 attached to the on-board
> > + * i2c controller, but the i2c adapter driver in the binary
> > + * nvidia superblob driver sets class to 0.
> > + */
> > + if (!(adapter->class & I2C_CLASS_HWMON) && adapter->class)
> > + return 0;
>
> NACK on that comment and associated code: Jean Delvare submitted a
> patch to NVIDIA over two years ago to fix their bug. Apparently some
> distros even carry his patch. So, I don't want to encourage such a
> hack to persist. Please just do the standard check here.
For the records: this patch exists but I did not send it to nVidia. For
legal/license reasons I do not want to be considered a contributor to
the nvidia Linux driver. So someone else will have to send the patch to
nVidia. I would hope that this was already done by now, but maybe not.
--
Jean Delvare
