Hi: * Jean Delvare <khali at linux-fr.org> [2008-02-13 21:35:33 +0100]: > Hi Rudolf, > > On Fri, 18 Jan 2008 00:42:54 +0100, Rudolf Marek wrote: > > This patch updates my previous patch with Jeans valuable comments - yeah thanks! > > Compile tested this time. > > > > Following patch will add reporting of maximum temperature, at which all fans > > should spin full speed. It may be non-physical temperature on Desktop/Server CPUs. > > > > Signed-off-by: Rudolf Marek <r.marek at assembler.cz> > > Tested on my Core T2600, it doesn't have the feature but at least I > confirm that there is no regression. > > I reviewed the code, it looks OK to me this time. > > Acked-by: Jean Delvare <khali at linux-fr.org> > > Just one comment: > > > + err = device_create_file(&pdev->dev, > > + &sensor_dev_attr_temp1_max.dev_attr); > > It should be possible to make this line fit in the 80-column limit. I fixed that up & applied to hwmon-2.6.git/testing, thanks. -- Mark M. Hoffman mhoffman at lightlink.com
