Hi Juerg, On Thu, 4 Oct 2007 21:15:10 -0700, Juerg Haefliger wrote: > Hi Jean, > > On 10/4/07, Jean Delvare <khali at linux-fr.org> wrote: > > On Mon, 1 Oct 2007 21:19:04 -0700, Juerg Haefliger wrote: > > > This patch cleans up and prepares the dme1737 driver for support of the sch311x > > > chips. (Almost) no functional changes. > > > > > > - Replaced whitespaces with tabs. > > > - Removed empty lines. > > > - Added _i2c_ to names of functions that are strictly I2C related. > > > - Added 4 new functions: dme1737_create_files, dme1737_remove_files, > > > dme1737_sio_enter, and dme1737_sio_exit. > > > - Added error messages in case client attach/detach fails. > > > > Not really, as you backed up (most of) these changes. Anyway... > > > > > Signed-off-by: Juerg Haefliger <juergh at gmail.com> > > > > Acked-by: Jean Delvare <khali at linux-fr.org> > > > > Note that I had to replace all occurrences of "class_dev" to > > "hwmon_dev", otherwise this patch doesn't apply on top of "hwmon: > > Convert from class_device to device" in Mark's tree. > > Ok. How can I create patches against the (latest) hwmon tree? Do I > need to git-clone it? If yes, how? > git-clone git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git doesn't > seem to give me the latest and greatest. You need to specifically ask for branch "testing". But if you have a 2.6.23-rc9 tree at hand (as I do) it's IMHO easier to just pick git-hwmon.patch in Andrew's latest tree: http://www.eu.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/broken-out/git-hwmon-fixup.patch And apply it on top of your tree, and then add your own patches on top of that. -- Jean Delvare