Hi Darrick, On Wed, 29 Aug 2007 07:50:03 -0700, Darrick J. Wong wrote: > On Wed, Aug 29, 2007 at 11:10:52AM +0200, Jean Delvare wrote: > > > I'm not sure if we want these "historical" files. We don't have them for > > the other input types, and I believe that it's not the driver's job to > > compute and export these values. If anyone cares about the history of > > In the case of ibmpex, it is the _hardware_ that computes the historical > data; the driver merely exports what it sees. OK, that's a bit different then, but I'm still not sure that there is much value in exporting these values in sysfs, in particular if there is no way to reset them. I am also not happy with the names you proposed: power1_max_input and power1_min_input are somewhat confusing IMHO, I'd suggest power1_input_highest and power1_input_lowest to make them clearly different from the min and max limits we have for other sensor types. If we have them at all, of course. -- Jean Delvare
