Hi Krzysztof, On Sat, 04 Aug 2007 13:56:31 +0200, Krzysztof Helt wrote: > From: Krzysztof Helt <krzysztof.h1 at wp.pl> > > This patch adds individual alarm and fault files to > the thmc50 driver. These sysfs entries are required > for a new libsensors library. > > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl> Thank for working on this. Your patch works, but it's not very efficient. You could pass the bit shift value directly in index for each alarm and fault file, rather than computing it again each time. Then you could have a single callback for alarms and faults. Please see the lm90 driver for an example of this implementation. Thanks, -- Jean Delvare
