Hi all, Twice in the past 2 weeks, I have been criticized for being too demanding in my hwmon patch reviews. I have been told that I was wasting developers' time and taking the fun away from them. Well, I am also no longer having fun reviewing patches when I am "rewarded" this way. Not that reviewing patches is really fun to start with, you usually don't receive much thank nor praise, but receiving criticism is going one step too far. It has been suggested that I should review patches differently and accept more divergence from what I consider the right way. This isn't going to happen, sorry. Given that I am not paid for the job, nobody gets to tell me which patches I should review and how. But I also don't want to cause contributors to leave the project. As a consequence, I have decided to change my behavior with regards to the patches which are posted to the lm-sensors list. I will no longer review random patches. I will only review patches meeting any of the following conditions: * I asked for that patch. * The patch is for a hwmon driver I am maintaining. * The author explicitly asked me to review his/her work, and I feel like it. * Mark asked me to review the patch. Hopefully this will prevent further tensions from arising. -- Jean Delvare
