try to run MAKEDEV if i2c-dev device files are missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>       Author: jwrdegoede
>         Date: Fri Jul  6 21:39:39 2007
> New Revision: 4571
>    Changeset: http://lm-sensors.org/changeset/4571
> 
> Modified:
>    lm-sensors/trunk/prog/detect/sensors-detect
> 
> Log:
> try to run MAKEDEV if i2c-dev device files are missing before aborting (adapted fedora patch)

> --- /lm-sensors/trunk/prog/detect/sensors-detect (revision 4568)
> +++ /lm-sensors/trunk/prog/detect/sensors-detect (revision 4571)
> @@ -2175,6 +2175,9 @@
>    }
>  
>    if (!($use_devfs || $use_udev)) {
> +    if (! -c '/dev/i2c-0' && -x '/sbin/MAKEDEV') {
> +      system("/sbin/MAKEDEV i2c");
> +    }
>      if (-c '/dev/i2c-0') {
>        $dev_i2c = '/dev/i2c-';
>      } else { # default

Another good catch, and maybe we can improve it a bit.

First of all, a question: how many i2c device nodes does your MAKEDEV
create? The one I have in Slackware 9.1 only creates i2c-0 and i2c-1.
This might not be sufficient. Not our fault though.

Secondly, MAKEDEV was in /dev on Slackware, so maybe we could test both
locations?

Then, the good news is that we should be able to drop the reference to
prog/mkdev/mkdev.sh, and finally delete it from the lm-sensors package
(in branch 3.0.0). I don't plan to move it to i2c-tools. On new systems
it's not needed. On old systems, MAKEDEV should do the work.

Thanks,
-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux