[PATCH] Add temperature-tracking mode to f71805f driver (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jean Delvare wrote:

(in the sysfs documentation)
>> +OR
>> +
>> +pwm[1-*]_auto_point[1-*]_temp
>> +pwm[1-*]_auto_point[1-*]_fan
>> +		Define the fan speed vs temperature curve for chips which
>> +		associate trip points to PWM output channels.  Number of trip
>> +		points is chip-dependent.
>>  		RW
>
> This was discussed some times ago and the consensus was that we did not
> want to extend this documentation for every new chip doing things
> differently

Well currently the file documents 2 of the n ways in which it can work 
as if they are the only two ways.

Would you not prefer to insert at least some mention that it could work 
in other ways?  Put yourself in the position of someone who has a board 
with one of these chips, who wants to configure it.  If the method is 
left undocumented, they have to guess or read the source.

I would not be pleased if the functionality that I have added goes 
unused because the documentation for it has been rejected.


Phil.










[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux