[PATCH 1/2] hwmon/sis5595: Convert to a platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Jean,

I can't get _anything_ to enter my logs. Is there something required, 
besided enabling the hwmon debugging messages? I've tried to find more 
information about logging on the web, but couldn't find anything relevant.

Ivo
----- Original Message ----- 
From: "Jean Delvare" <khali at linux-fr.org>
To: "Ivo Manca" <pinkel at gmail.com>
Cc: "LM Sensors" <lm-sensors at lm-sensors.org>
Sent: Wednesday 6 June 2007 14:51
Subject: Re:  [PATCH 1/2] hwmon/sis5595: Convert to a platform 
driver


> Ivo,
>
> Please don't forget the mailing list!
>
> On Wed, 6 Jun 2007 13:21:23 +0200, Ivo Manca wrote:
>> [root at localhost ~]# sensors -v
>> sensors version 2.10.1 with libsensors version 2.10.1
>>
>> I'll update it if you want.
>
> No, that should be OK.
>
>> > If you already have lm-sensors version >= 2.10.1, please compile with
>> > CONFIG_HWMON_DEBUG_CHIP=y and look into your logs when loading the
>> > driver. Also check what you see under /sys/class/hwmon
>> > and /sys/bus/platform.
>>
>> I already enabled hwmon_debug_chip, however, nothing seems to get logged. 
>> It
>> should go somewhere to /var/log, shouldn't it? Only log file changing is 
>> my
>> messages, but that's just moaning about  nmbd ;)
>
> If should show in the output of "dmesg" to start with, and indeed also
> in /var/log/messages and/or /var/log/debug.
>
>> [ivo at localhost log]$ ls -l /sys/class/hwmon/
>> total 0
>>
>> [ivo at localhost log]$ ls -lR /sys/bus/platform/
>> /sys/bus/platform/:
>> total 0
>> drwxr-xr-x 2 root root    0 Jun  6 10:05 devices
>> drwxr-xr-x 4 root root    0 Jun  6 10:05 drivers
>> -rw-r--r-- 1 root root 4096 Jun  6 10:56 drivers_autoprobe
>> --w------- 1 root root 4096 Jun  6 10:56 drivers_probe
>>
>> /sys/bus/platform/devices:
>> total 0
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 floppy.0 ->
>> ../../../devices/platform/floppy.0
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 i8042 ->
>> ../../../devices/platform/i8042
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 microcode ->
>> ../../../devices/platform/microcode
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 pcspkr ->
>> ../../../devices/platform/pcspkr
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 serial8250 ->
>> ../../../devices/platform/serial8250
>> lrwxrwxrwx 1 root root 0 Jun  6 10:05 serial8250.0 ->
>> ../../../devices/platform/serial8250.0
>>
>> /sys/bus/platform/drivers:
>> total 0
>> drwxr-xr-x 2 root root 0 Jun  6 10:05 i8042
>> drwxr-xr-x 2 root root 0 Jun  6 10:05 serial8250
>>
>> /sys/bus/platform/drivers/i8042:
>> total 0
>> --w------- 1 root root 4096 Jun  6 10:57 bind
>> lrwxrwxrwx 1 root root    0 Jun  6 10:57 i8042 ->
>> ../../../../devices/platform/i8042
>> --w------- 1 root root 4096 Jun  6 10:57 unbind
>>
>> /sys/bus/platform/drivers/serial8250:
>> total 0
>> --w------- 1 root root 4096 Jun  6 10:57 bind
>> lrwxrwxrwx 1 root root    0 Jun  6 10:57 serial8250 ->
>> ../../../../devices/platform/serial8250
>> lrwxrwxrwx 1 root root    0 Jun  6 10:57 serial8250.0 ->
>> ../../../../devices/platform/serial8250.0
>> --w------- 1 root root 4096 Jun  6 10:57 unbind
>
> Odd. No sign of sis5595 anywhere.
>
>> [ivo at localhost log]$ lsmod
>> Module                  Size  Used by
>> sis5595                14348  0
>> i2c_sis5595            10244  0
>> i2c_dev                 9860  0
>> hwmon                   6404  1 sis5595
>> ne2k_pci               12128  0
>> 8390                   11520  1 ne2k_pci
>>
>> /sys/class/hwmon shouldn't be empty, should it?
>
> It shouldn't, but OTOH given that the sis5595 platform driver seemingly
> wasn't registered properly, I am not surprised.
>
> My previous patch had some error paths which didn't display any error
> nor debug message. I guess that one of these error conditions occurred
> and this is why you don't see anything in the logs. So I attached a new
> version of the patch with messages on all the error paths. Please
> revert the previous patch and apply this one instead, leaving debugging
> enabled of course. Hopefully you'll have something in the log this
> time, and from there we'll see what needs to be fixed.
>
> Thanks,
> -- 
> Jean Delvare
> 





[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux