[PATCH] Add MAX6650 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2007-03-16 at 22:19 +0100, Hans-J?rgen Koch wrote:
> Am Freitag, 16. M?rz 2007 22:19 schrieb Thomas Gleixner:
> > On Fri, 2007-03-16 at 22:07 +0100, Hans-J?rgen Koch wrote:
> > > > > /* fan_voltage: 5=5V fan, 12=12V fan, 0=don't change */
> > > > > static int fan_voltage = 0;
> > > > > /* prescaler: Possible values are 1,2,4,8,16, or 0 for don't change
> > > > > */ static int prescaler = 0;
> > > >
> > > > The trick is to _not_ initialize these variables at all. The compiler
> > > > will put them in a special section and will zero them all at once
> > > > automatically.
> > >
> > > Sounds dangerous. But I trust you :-)
> >
> > It's one of the things which actually work reliable in gcc :)
> >
> > 	tglx
> 
> Fine, I'll remember that. But I think readability is better if you explicitly 
> initialize to zero. Is that optimization really worth it?

The zeroed segment is set with memset() in one go, while all explicit
initializations carry additional code. gcc might be clever enough now to
move a "=0" initialized variable to the zeroed segment, but it is common
style since ever. And it removes _three_ characters per variable :)

	tglx






[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux