Add 2 attr-file groups (for base and model-specific attrs respectively), create the base group with single call to sysfs_create_group, and check the return code on individual calls to device_create_file for each of the model-specific attr-files. Signed-off-by: Jim Cromie <jim.cromie at gmail.com> --- all suggestions incorporated. [jimc at harpo hwmon-stuff]$ diffstat hwmon-unchecked-return-status-fixes-w83781d.patch w83781d.c | 265 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 141 insertions(+), 124 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: hwmon-unchecked-return-status-fixes-w83781d.patch Type: text/x-patch Size: 14593 bytes Desc: not available Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060922/9f119b79/attachment.bin