Hi Jean, > Hmmm, so you permuted temp1, temp2 and temp3 compared to the Linux 2.4 > driver. While I was OK with swapping temp1 and temp3 (in line with the > datasheet), I'm not as happy with changing temp2. It makes matching > with the datasheet harder. > > What are the benefits? Making ISTEMP() more simple, and getting rid of > TEMPIX_FROM/TO_REG()? Oh yes! The mapping is screwed either way, just in different places. This way the code is simpler and easier to read. > > + /* Read VID and set VRM */ > > + data->vid = vt1211_read8(data, VT1211_REG_VID) & 0x1f; > > Any reason why this is only read once, rather than updated on every > read? That's a static value, isn't it? Why read it more than once? ...juerg
