[PATCH 1/2 RESEND 2] hwmon: new vt1211 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

> Really, I don't think so. That's what we have in the 2.4 driver:
>
> http://www.lm-sensors.org/browser/lm-sensors/trunk/kernel/chips/vt1211.c
>
> 122     static const u8 regtemp[] = { 0x20, 0x21, 0x1f, 0x22, 0x23, 0x24, 0x25 };
> 123     static const u8 regover[] = { 0x39, 0x3d, 0x1d, 0x2b, 0x2d, 0x2f, 0x31 };
> 124     static const u8 reghyst[] = { 0x3a, 0x3e, 0x1e, 0x2c, 0x2e, 0x30, 0x32 };
>
> regtemp is similar, but regover and reghyst have their 1st and 3rd
> elements swapped. The datasheet matches your version, so this has to be
> a bug in the 2.4 driver. In doubt, you could check if the alarm flags
> for temp1 and temp3 trigger as expected.

OK, yes. Now I remember. Regover and reghyst in 2.4 are correct but
regtemp has elements 1 and 3 swapped (compared to the datasheet). I
kept the swapping but fixed regover and reghyst to stay compatible
with sensors.conf. If we want to follow the datasheet (rev 1.42) it
would have to be as follows:

static const u8 regtemp[] = { 0x1f, 0x21, 0x20, 0x22, 0x23, 0x24, 0x25 };
static const u8 regover[] = { 0x39, 0x3d, 0x1d, 0x2b, 0x2d, 0x2f, 0x31 };
static const u8 reghyst[] = { 0x3a, 0x3e, 0x1e, 0x2c, 0x2e, 0x30, 0x32 };

i.e.:
temp1 = Reading 1
temp2 = Reading 2
temp3 = Reading 3
temp4 = UCH2
temp5 = UCH3
temp6 = UCH4
temp7 = UCH5

...juerg




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux