[PATCH 1/2 RESEND 2] hwmon: new vt1211 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

> > particular speed zone. The current PWM value changed accordingly so
> > I'm pretty sure it's working even though my fan is not connected to
> > the PWM output :-)
>
> OK. I'd be nice if someone could test it with a real fan, though.

Sure, if someone has a vt1211-based board that actually has the fan
connected to the PWM output. I haven't seen one yet...

And sometimes I'm wondering why do I put so much effort into
implementing PWM if none of the VIA boards actually uses the PMW
outputs? sigh...


> The driver should provide the functions the chip provides. Any form of
> emulation belongs to user-space. So I think you should wipe out the
> manual mode from the driver entirely (it doesn't work as documented),
> and only leave off (0) and automatic (2) modes. The nice side is that
> it solves the "pwm1 and pwm2 can't mix modes" issue.

Will do. Makes my life certainly easier :-)

...juerg


> Then you can document your trick above, if you want. This should work
> for any chip with automatic mode, it's not really VT1211-specific. It's
> just so rare that a chip can do automatic fan speed control, but not
> manual.
>
> --
> Jean Delvare
>




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux