[PATCH] hwmon: re-order CONFIG_HWMON_DEBUG_CHIP Kconfig entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arthur,

Care to change your "From:" to the standard notation?

> Move CONFIG_HWMON_DEBUG_CHIP higher up so it's more accessible.
> 
> Signed-off-by: Arthur Othieno <apgo at patchbomb.org>
> ---
>  drivers/hwmon/Kconfig |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 0e31a0c..5284491 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -23,6 +23,16 @@ config HWMON
>  	  This support can also be built as a module.  If so, the module
>  	  will be called hwmon.
>  
> +config HWMON_DEBUG_CHIP
> +	bool "Hardware Monitoring Chip debugging messages"
> +	depends on HWMON
> +	default n
> +	help
> +	  Say Y here if you want the I2C chip drivers to produce a bunch of
> +	  debug messages to the system log.  Select this if you are having
> +	  a problem with I2C support and want to see more of what is going
> +	  on.
> +
>  config HWMON_VID
>  	tristate
>  	default n
> @@ -507,14 +517,4 @@ config SENSORS_HDAPS
>  	  Say Y here if you have an applicable laptop and want to experience
>  	  the awesome power of hdaps.
>  
> -config HWMON_DEBUG_CHIP
> -	bool "Hardware Monitoring Chip debugging messages"
> -	depends on HWMON
> -	default n
> -	help
> -	  Say Y here if you want the I2C chip drivers to produce a bunch of
> -	  debug messages to the system log.  Select this if you are having
> -	  a problem with I2C support and want to see more of what is going
> -	  on.
> -
>  endmenu

I'm not convinced sorry. It is common to have the debug options after
the affected drivers, be they individual or not. And the bottom of the
screen isn't that far ;)

What would be much more interesting would be to update the text and
replace occurences of "I2C" by "hardware monitoring"! One mode stupid
copy-n-paste typo. Care to send a patch?

Thanks,
-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux