On Mon, Jul 03, 2006 at 12:12:47PM +0200, Stelian Pop wrote: > > + > > +static DEVICE_ATTR(mouse, S_IRUGO | S_IWUSR, > > + ams_mouse_show_mouse, ams_mouse_store_mouse); > I would prefer three different files for x, y and z instead of a single > one... Because of the way the values are calculated with orientation, that would mean that if a program needs all three, either all values are read three times or the ams_sensors function gets much more complicated. To prevent it from having to read them three times in a row, I joined all three values. Do you think I should rewrite the ams_sensors function to only get the correct value? Thanks, Michael (All other issues, including those in the other mails, are clear and will be addressed by a new patch)
