Jean Delvare wrote: > Hi Hans, > >> Now that the abituguru driver is seeing some more widespread testing it >> has turned out that one the first generation of Abit uGuru motherboards, >> with uGuru revision 1, the autodetect bank1 sensor type code doesn't >> (always) work. >> >> Thispatch adds a module param to override the autodetect, and it adds >> validity checks for the value of the 2 other autodetection override >> module params. An example of howto use the new param can be found here: >> http://lm-sensors.org/wiki/Configurations/Abit/AN7 >> >> It would be nice if this patch could be merged before 2.6.18, as without >> it the uguru driver is useless for people with the affected motherboards. > > Fine with me, except for: > >> --- linux-2.6.17-rc4-mm1.orig/drivers/hwmon/abituguru.c 2006-06-25 13:49:18.000000000 +0200 >> +++ linux-2.6.17-rc4-mm1/drivers/hwmon/abituguru.c 2006-06-25 13:51:17.000000000 +0200 >> @@ -142,6 +142,14 @@ >> static int force; >> module_param(force, bool, 0); >> MODULE_PARM_DESC(force, "Set to one to force detection."); >> +static int bank1_types[16] = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, >> + -1, -1, -1, -1 }; > > This "16" is actually ABIT_UGURU_MAX_BANK1_SENSORS, right? > You're right. I've attached a new version of the patch with this fixed. Regards, Hans -------------- next part -------------- A non-text attachment was scrubbed... Name: hwmon-abituguru-override-bank1detect.patch Type: text/x-patch Size: 2405 bytes Desc: not available Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060627/aa6dc1f2/attachment.bin
