[PATCH] W83627EHF driver update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rudolf,

> > > > Using SENSOR_LIMIT here doesn't make sense, as we're not dealing with a
> > > > range. Better return -EINVAL if value is neither 0 nor 1.
> > >
> > > Well yes why not, maybe we should write a note to a docs?
> > 
> > I think the best we can do is to make it right in our drivers, because
> > this is where people look when writing new drivers. If you want to
> > extend the sysfs-interface documentation file to describe how invalid
> > values should be handled (on write), feel free to do so.
> 
> Ok
> 
> Well they are handled at least with two different ways.
> 
> 1) -EINVAL
> 2) if out of bounds - nearest bound is written

First for discrete values, second for ranges. This makes sense, and is
still simple enough so everyone should be able to get it.

-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux