Hi Hans, > This is what I had in mind too, done. The attached patch fixes this as > requested and also fixes the requested should fixes, changes: > - exactly calculate the sysfs_names array length using macro > - use snprintf when generating names to double check that the > sysfs_names array does not overflow. > - use ARRAY_SIZE and / or defines to determine number of loops in for > loops instead of using hardcoded values. > - In abituguru_probe(), refactor the error path leaving a single call > to kfree Looks good, thanks! I'll push the abituguru driver upstream in the next batch of patches (not scheduled yet.) -- Jean Delvare
