[PATCH 2.6.17-rc4] I2C: sis96x SMBus quirks cannot rely on link ordering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean:

* Jean Delvare <khali at linux-fr.org> [2006-05-24 09:57:30 +0200]:
> Sorry for the late reply.
> 
> > The sis96x SMBus PCI device depends on the order of two different
> > quirks, which depends on link order.  But this is apparently not
> > guaranteed, as seen on a recent FC4 kernel.  This patch fixes the
> > quirk so that it works without depending on the link order.
> > 
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2006-April/015962.html
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189719
> > 
> > This code was suggested by Jean Delvare; the patch was tested and
> > should be considered for 2.6.17.
> 
> I'm happier with this patch than the previous one. However, I'm still
> not really comfortable with it. Given that we don't understand why the
> quirk order suddenly became untrustworthy, it's hard to justify that we
> want this fix in 2.6.17, especially when vanilla kernels are not
> affected by the problem as far as I know.
> 
> At any rate, this patch does belong to the pci tree and not the i2c
> tree, so I am not the one who can push it. Please post this patch on
> the linux-pci list and get it discussed there. Hopefully the people
> there will be able to explain how the quirks sequencing works.

That's fair enough.

> (Please put me in Cc, I'm interested in the answer.)

Thanks,

-- 
Mark M. Hoffman
mhoffman at lightlink.com





[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux