Patch regarding the I2C_HEADERS variable in 'lm_sensors2/Makefile'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alon,

> I consider the following as a nuisance, but still a bug.
> I've noticed that lm_sensors's compilation always assumes that there
> is a special path for i2c headers, which is held in I2C_HEADERS
> (default is '/usr/local/include'). In my opinion, it should be
> possible to unset that variable, in case there is no such special
> path. The attached patch does exactly that.

I disagree.

You can have installed i2c in two different ways: either you patched it
into your kernel sources, or you installed it externally. In the former
case, you must set I2C_HEADERS to point to your kernel source tree. In
the latter case, you must set I2C_HEADERS to point to
/usr/local/include (the default) or wherever you installed the headers
that come from the i2c package. This should not be /usr/include, as
this directory contains the kernel headers the glibc was compiled with
and they should never be changed when installing a new kernel.

So in both cases, I2C_HEADERS points to a non-standard location and
needs to be set, or gcc won't find the header files.

-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux