[PATCH] remove the fix_hstcfg from i2c-piix4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean
>>+If you have some rather strange SMBus problems, you may need to change the
>>+SMBus Interrupt Select register as it is known solution for Force CPCI735
>>+motherboard or other OSB4 based systems. Please contact us for further
>>+assistance (lm-sensors at lm-sensors.org).
> 
> 
> Oh, no. We don't want more support requests on this. Instead, please
> explain how to get the register value using lspci and how to write back
> the modified value using setpci.

Well I think there will be requests like same probability that you capture your
very own neutrino :)

Anyway I will prepare the DIY guide.

> 
> Besides, are you sure that other OSB4 based systems did need this? I've
> searched all my mails, and couldn't find anyone reporting success after
> using fix_hstcfg, except Tom.
> 

The old text suggest this. All I think is that the bios left the controller in
interrupt mode and I think our driver assumes always the SMI mode.


> 
>>-	if ((temp & 0x0E) == 8)
>>+	if (((temp & 0x0E) == 8) || ((temp & 0x0E) == 2))
> 
> 
> I think I understand that 8 is OK for non-Serverworks one and 2 is OK
> for Serverworks one, right? So maybe we can improve this check and do:
> 
> if ((temp & 0x0E) == (id->vendor == PCI_VENDOR_ID_SERVERWORKS ? 2 : 8))

I thought about this but for the reason that serverworks was bought by broadcom
and we have ATI and others there so best sounds to me to make it more global.

Regards
Rudolf






[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux