On Tue, Mar 28, 2006 at 02:21:14PM +0200, Jean Delvare wrote: > Hi Mark, Andrew, > > > Mark A. Greer wrote: > > > > > > Resend... > > > --- > > > > > > drivers/i2c/chips/m41t00.c | 294 ++++++++++++++++++++++++++++++++++----------- > > > include/linux/m41t00.h | 50 +++++++ > > > > Andrew Morton wrote: > > Not sure what to make of this. It has no changelog, Oops. My bad. > > it doesn't apply on > > top of your previous three patches: > > > > rtc-m41t00-driver-should-use-workqueue-instead-of-tasklet.patch > > rtc-m41t00-driver-cleanup.patch > > rtc-add-support-for-m41t81-m41t85-chips-to-m41t00-driver.patch > > > > and it doesn't apply when used to replace > > rtc-add-support-for-m41t81-m41t85-chips-to-m41t00-driver.patch. > > Replacing works for me, after also replacing the two first patches of > the series with their new respective version. As for the changelog I > picked the one from the original third patch. Sorry for the confusion, Andrew. The 3 patches I sent were all replacement patches for the previous 3 patches. > > An incremental patch against the three above patches would be ideal... I would have done that but there wasn't a 2.6.16-mm2 patch yesterday (that I see is there now) so I had nothing to diff against. <snip> > Mark, is it OK if this third patch adding the m41t81 and m41t85 support > spends some time in Andrew's tree and only goes in mainline for 2.6.18, > or do you need it in 2.6.17? No, waiting is fine, Jean. Thanks guys. Mark