Hi Andrew, On Sun, Mar 26, 2006 at 02:58:40PM -0800, Andrew Morton wrote: > "Mark A. Greer" <mgreer at mvista.com> wrote: > > > > + struct i2c_msg msgs[] = { > > + { save_client->addr, 0, 1, msgbuf }, > > + { save_client->addr, I2C_M_RD, 8, buf } > > The > > .name = value, > > form would be preferred. It reduces the possibility of silent breakage if > someone changes struct i2c_msg. Noted. Will fix in upcoming set of new patches. Mark