Bug in initialisation of stopped RTC's in ds1337.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hallo Michael,

On 2006-02-23, Michael Burian wrote:
> The current initialisation code for handling the "RTC not running" case
> is buggy. Overwritting the whole 16 regs with zero turned out to be a
> bad idea.
> (...)
> The attached patch can be applied against mainline and should fix the
> problem by detecting if the RTC is not running, changing 2 bits (OSF,
> EOSC) as necessary, and no longer overwriting the whole 16 regs.
>
> Please review, thanks

Looks sane to me, but I don't have a device to test it, and the 16-reg
zeroing might have been done for a reason. James, can you please comment
on the patch and test it?

--
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux