Hi Ben,
> scx200_acb refactor/simplify code (no functional changes).
> + dev_dbg(&iface->adapter.dev, "negative ack in state %s\n",
> (...)
> - dev_dbg(&iface->adapter.dev, "negative acknowledge in state %s\n",
Functional change, you changed the debug message ;)
> if (!iface) {
> printk(KERN_ERR NAME ": can't allocate memory\n");
> - rc = -ENOMEM;
> - goto errout;
> + return -ENOMEM;
> }
Some people seem to prefer single exit point, so you could preserve the
errout label right before the trailing return, and keep that code.
--
Jean Delvare
