Hi Ben, > scx200_acb whitespace and comment cleanup. Looks like you have been over-zealous here. These three types of changes in this patch are not really wanted: > -#define NAME "scx200_acb" > +#define NAME "scx200_acb" > - struct scx200_acb_iface *next; > - struct i2c_adapter adapter; > - unsigned base; > - struct semaphore sem; > + struct scx200_acb_iface *next; > + struct i2c_adapter adapter; > + unsigned base; > + struct semaphore sem; > iface->result = 0; > - iface->state = state_idle; > + iface->state = state_idle; Given that different developers like it differently and there is no absolute rule for these points, and given that the scx200_acb driver is consistent with regards to these points, I'd leave the current code as it is. All other changes (in this patch) I am fine with. Thanks, -- Jean Delvare
