[PATCH] lm_sensors2 w83792d clear/simplify code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yuan,

> This patch collect simplifies and clear patches Jean has done with hwmon
> w83792d driver.
> And Fix the tolerance 2 and tolerance 3 can not be set bug.
> 
> I hope this patch is right, please can you check :)

Patch looks OK, except for data->low_bits which you had set to u8 while
it must be u16 (you have to fit 14 bits in there). I've just applied
it. Thanks for your contribution!

I noticed another bug in the w83792d driver while verifying your patch:
the fan control mode (PWM/DC) was not reported properly due to a typo
([1] instead of [i]). I've fixed that too. Linux 2.6 is not affected.

Thanks,
-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux