Ben Gardner <gardner.ben at gmail.com> wrote: > > +/* These are defined in cs5535.c */ > +extern u32 cs5535_gpio_base; > +extern u32 cs5535_gpio_mask; And they should be declared in a header file, please. Is there a reason for these being exported to non-GPL modules, or can they be EXPORT_SYMBOL_GPL()?