Hi Mark, > dev_err(&drv_data->adapter.dev, > - "mv64xxx: I2C bus locked\n"); > + "mv64xxx: I2C bus locked, block: %d," > + " time_left: %d, before: %d, after: %d\n", > + drv_data->block, time_left); Please put the middle space at the end of the first half of the string rather than the beginning of the second half. Following this arbitrary rule makes it easier to spot split strings missing their middle space(s). The parameter count for dev_err() is also not correct, the string has four %d and you provide only two values. I'd be surprised it even compiles. -- Jean Delvare
