Hi Jean, On Tue, Nov 15, 2005 at 09:52:26PM +0100, Jean Delvare wrote: <snip> > First, a question. Can't you merge the M41T85 support into the m41t00 > driver? > > Mark, care to comment on that possibility, and/or on the code itself? Sure. I wrestled with the ST website for the m41t85 datasheet but lost so I I can only guess from the patch. The drivers do look very similar. It looks like the m41t85 is basically a m41t00 with an alarm (watchdog timer never used AFAICT). Also there are some differences in register offsets and [maybe] some minor differences within the registers but nothing that serious. I think we can combine the two into an m41txx.c and pass the exact type in via platform_data--that would be the correct mechanism, right? The platform_data could also be used to seed the correct SQW freq and eliminate all the Kconfig noise. Comments? As for Jean's and Andrew's comments about the driver, they seem valid to me and should be addressed. In Andrey's defense, many of them are my fault. Once there is a consensus on the merging m41t00 & m41t85 question, I'll try to get a fixed up patch within a couple weeks. Mark
