Hi Mark,
On 2005-10-12, Mark M. Hoffman wrote:
> This patch adds a new ID to the SMSC LPC47B397-NC hardware
> monitoring driver - for a chip that is claimed to be 100%
> compatible otherwise.
> (...)
> - printk(KERN_INFO "smsc47b397: found SMSC LPC47B397-NC "
> - "(base address 0x%04x, revision %u)\n", *addr, rev);
> + switch (id) {
> + case 0x6f:
> + printk(KERN_INFO "smsc47b397: found SMSC LPC47B397-NC "
> + "(base address 0x%04x, revision %u)\n", *addr, rev);
> + break;
> + case 0x81:
> + printk(KERN_INFO "smsc47b397: found SMSC SCH5307-NS"
> + "(base address 0x%04x, revision %u)\n", *addr, rev);
> + break;
> + }
This adds some redundancy. What about the following?
printk(KERN_INFO "smsc47b397: found %s "
"(base address 0x%04x, revision %u)\n",
id == 0x81 ? "SMSC SCH5307-NS" : "SMSC LPC47B397-NC",
*addr, rev);
I would also appreciate an update to Documentation/hwmon/smsc47b397.
Thanks,
--
Jean Delvare
