[PATCH 2.6] hwmon: fix sis5595, via686a force_addr module parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Recent changes to the i2c-isa design broke the force_addr parameter of
two hardware monitoring drivers as a side effect: sis5595 and via686a.
The last address test was in fact useless beforehand, and the redesign
turned it into a bug. I'm sorry about that.

Signed-off-by: Jean Delvare <khali at linux-fr.org>

 drivers/hwmon/sis5595.c |    5 -----
 drivers/hwmon/via686a.c |    5 -----
 2 files changed, 10 deletions(-)

--- linux-2.6.13-git7.orig/drivers/hwmon/sis5595.c	2005-09-08 10:42:51.000000000 +0200
+++ linux-2.6.13-git7/drivers/hwmon/sis5595.c	2005-09-08 11:51:46.000000000 +0200
@@ -758,11 +758,6 @@
 		return -ENODEV;
 	}
 
-	if (!address) {
-		dev_err(&dev->dev,"No SiS 5595 sensors found.\n");
-		return -ENODEV;
-	}
-
 	s_bridge = pci_dev_get(dev);
 	if (i2c_isa_add_driver(&sis5595_driver)) {
 		pci_dev_put(s_bridge);
--- linux-2.6.13-git7.orig/drivers/hwmon/via686a.c	2005-09-08 11:42:22.000000000 +0200
+++ linux-2.6.13-git7/drivers/hwmon/via686a.c	2005-09-08 11:51:37.000000000 +0200
@@ -812,11 +812,6 @@
 		return -ENODEV;
 	}
 
-	if (!address) {
-		dev_err(&dev->dev, "No Via 686A sensors found.\n");
-		return -ENODEV;
-	}
-
 	s_bridge = pci_dev_get(dev);
 	if (i2c_isa_add_driver(&via686a_driver)) {
 		pci_dev_put(s_bridge);


-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux