Hi Grant, > Patches are planned to make chassis_clear write data = > <dont_care>, With what benefit? > and rework sysfs interface to reduce driver size. Are you referring to Yani Ioannou's dynamic sysfs callbacks? That would be very welcome, thanks for looking into that. > This patch removes mixed tab/space indenting, There is nothing wrong with mixed tab/space indenting. Additionally, this part of the code will be completely modified again if you convert the driver to use dynamic callbacks. So I would like you not to include these changes in this cleanup patch. > breaks long lines, Good. > removed a trailing space Good too. Thanks, -- Jean Delvare
