[PATCH 2.6.12-rc5-mm2] max6875: new i2c device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi again Ben,

One more thing about the max6875 driver. After reading the datasheet, I
think I understand that each chip will respond to two I2C addresses
(0x50+0x51 or 0x52+0x53). Your driver should allocate a subclient for
the second address (see the asb100 driver for an example) so as to
prevent another driver (e.g. eeprom) from requesting it and cause a
conflict. Also, this should give you the possibility to improve your
device identification procedure: if the same register or EEPROM location
read from both addresses return different results, this certainly is a
misdetection. And the sole fact of ensuring that the other address is
responsive will avoid some misdetections too.

Thanks,
--
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux