Hi Grant, > This patch removes non-i2c w83697hf, w83627thf sensor chips from the > w83781d driver. Compile tested. > > Also remove references to those sensor chips in w83781d docs. Great, except for: > - } > - > + Please avoid this "noise" change (same holds for all future patches, of course). > - if (kind != w83697hf) > - device_create_file_vid(new_client); > + device_create_file_vid(new_client); > > - if (kind != w83697hf) > - device_create_file_vrm(new_client); > + device_create_file_vrm(new_client); You could additionally remove the blank line in between, as vid and vrm are tightly linked. All the rest is OK, good work. -- Jean Delvare
