Hi Ben
> Please fix the driver so it works with -mm- kernels and maybe also the alphabetical issue.
Well (and this goes for your all your other -mm submissions too),
don't just fix it so it works with mm, fix it to take advantage of why
the changes (specifically dynamic sysfs callbacks) are there in the
first place.
> +#define store_data(enum_name) \
> +static ssize_t store_##enum_name(struct device *dev, const char *buf, size_t count) \
and here too.
> +{ \
> + pca9539_store_reg(dev, buf, enum_name); \
> + return count; \
> +}
Things like this are exactly what the change is supposed to rid us of,
please see the previous discussion and example patches in this thread:
http://lkml.org/lkml/2005/5/17/75
Thanks,
Yani
