Re: [RFC PATCH 2.6.12-rc3-mm2 1/2] i2c: new sysfs class "hwmon"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mark,

Sorry to bother you again, but would it be possible to see/explain
what modifications you plan to make to libsensors to read/write to
sensors for hwmon class devices, I'm in particular what specific sysfs
attributes you are reading from in /sys/class/hwmon/blah/.

At first I assumed you would probably be using the device_attributes
under /sys/class/hwmon/blah/device/ (assuming the particular hwmon
driver has an associated device - its optional), but on further though
that really doesn't make much sense because we would be assuming all
the hwmon class driver devices would share the same driver type (or
common sysfs device attribute interface)..which would sort of seem to
defy the whole point of having a hwmon class in the first place. From
what I see really we should be using class_device_attributes instead
of device_attributes for a hwmon driver, in which case I'm going to
have to submit a patch to Greg adding dynamic sysfs callbacks to
class_device_attribute sooner than I expected..

Using class_device_attributes would also lend the ability to, for
example, adding a hwmon interface to a device that's primary function
isn't to interface sensors, e.g. instead of having a bmcsensors driver
we would add a hwmon interface to the actual kernel IPMI bmc driver,
this would make much more sense to me.

Thanks,
Yani




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux