On 5/17/05, Grant Coady <grant_lkml at dodo.com.au> wrote: > Hi Yani, > > On Tue, 17 May 2005 16:56:04 -0400, Yani Ioannou <yani.ioannou at gmail.com> wrote: > >Those are the sysfs names? If so something looks wrong with the > > Not the final ones, just from first macro expansion of driver > source, that's why I'd like to see changes on w83627hf driver > as I can test it right through. > > No, I'm not doing a proper compile, I'm intentionally doing partial > compile of driver.c and _not_ including headers, ignoring errors due > to missing headers. Ah..OK, that is probably why, I've put the macros which would be expanded in the first level in a separate header because it will probably be shared amongst many drivers. Although I still don't see where SENSOR_blah is coming from at all at the moment, if you can track that down I'd be interested to know if its just something to do with the script or a problem with the patch. > Script is work in progress, updated to current version up at: > > http://scatter.mine.nu/hwmon/sysfs-names/ Ok, I'll have a look at it later. > > >The group of attributes you've highlighted below don't use > >sensor_device_attribute on purpose because they don't benefit from the > >dynamic sysfs callbacks, mainly because they are singletons. Well its > > Not singletons, 3 of each (from an intermediate file): > > adm1026.c temp1_crit_enable S_IRUGO S_IWUSR > adm1026.c temp2_crit_enable S_IRUGO S_IWUSR > adm1026.c temp3_crit_enable S_IRUGO S_IWUSR > adm1026.c pwm1 S_IRUGO S_IWUSR > adm1026.c pwm2 S_IRUGO S_IWUSR > adm1026.c pwm3 S_IRUGO S_IWUSR > adm1026.c temp1_auto_point1_pwm S_IRUGO S_IWUSR > adm1026.c temp2_auto_point1_pwm S_IRUGO S_IWUSR > adm1026.c temp3_auto_point1_pwm S_IRUGO S_IWUSR > adm1026.c temp1_auto_point2_pwm S_IRUGO > adm1026.c temp2_auto_point2_pwm S_IRUGO > adm1026.c temp3_auto_point2_pwm S_IRUGO > > Yet, in related groups of three you have: > > adm1026.c SENSOR_temp1_crit S_IRUGO S_IWUSR > adm1026.c SENSOR_temp2_crit S_IRUGO S_IWUSR > adm1026.c SENSOR_temp3_crit S_IRUGO S_IWUSR Well I said mainly singletons :-), some of the attributes don't benefit from the dynamic sysfs callbacks simply because they already only use one callback for a few different attributes, I believe that's the case with the non-singletons in this case. Thanks, Yani _______________________________________________ lm-sensors mailing list lm-sensors at lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
