On Wed, May 11, 2005 at 07:51:00AM +0100, Russell King wrote: > On Tue, May 10, 2005 at 03:16:15PM -0700, Greg KH wrote: > > +#define __ATTR(_name,_mode,_show,_store) { \ > > + .attr = { \ > > + .name = __stringify(_name), \ > > + .mode = _mode, \ > > + .private = NULL, \ > > We don't specifically initialise elements to NULL or zero. Is this a > change of policy? Doh, no, it isn't, you are correct. I've updated the patch, removing the changes to the __ATTR() and other macro that I modified. Thanks for catching this. greg k-h