Hi Rudolf, > I noticed that you added ESB2 support to i2c-i801.c Thats OK for 2.6 > kernels however for 2.4.x series it is needed too. (lm_sensors lives > outside 2.4 tree and its homepage is at http://www.lm-sensors.nu) > > I created neccessary patch that adds support to 2.4.x i2c-i801.c and > to our sensors-detect script (...) Thanks for looking into this. I have two minor coding-style comments: > --- lm_sensors2/kernel/busses/i2c-i801.c > +++ lm_sensors2_zmena/kernel/busses/i2c-i801.c > (...) > +/* ESB2 - Enterprise Southbridge is undefined */ > +#ifndef PCI_DEVICE_ID_INTEL_ESB2_17 > +#define PCI_DEVICE_ID_INTEL_ESB2_17 0x269b You have an extra space before the tab here. > --- lm_sensors2/prog/detect/sensors-detect > +++ lm_sensors2_zmena/prog/detect/sensors-detect > (...) > + match => sub { $_[0] =~ /^SMBus I801 adapter at [0-9a-f]{4}/ }, > + } , No space before comma please (although I know there are a lot in this file...) Otherwise it looks correct to me, providing Jason confirms your guesses. Thanks, -- Jean Delvare
