Hi Ladislav, hi all, > i2c_transfer returns number of sucessfully transfered messages. Change > error checking to accordingly. (ds1337_set_datetime never returned > sucess) I think you mean ds1337_GET_datetime, not ds1337_SET_datetime, never returned success? Anyway I like the patch, it makes the driver treat the value returned by i2c_transfer() properly and makes the code overall more consistent. Thanks, -- Jean Delvare