On Sat, Apr 16, 2005 at 06:49:22PM +0200, Jean Delvare wrote: > Hi Alexey, > > > Files that don't use CONFIG_* stuff shouldn't include config.h > > Files that use CONFIG_* stuff should include config.h > > > > It's that simple. ;-) > > I agree. This won't change anything though, as all drivers include > either device.h or module.h, which in turn include config.h. But you are > still correct, so I approve your patch. > > For completeness, I would propose the following on top of your own > patch: > > i2c bus drivers do not need to define DEBUG themselves, as the Kconfig > system takes care of it. > > Signed-off-by: Jean Delvare <khali at linux-fr.org> Applied, thanks. greg k-h