On Thu, Apr 07, 2005 at 04:36:29PM -0700, Greg KH wrote: > Oops, you forgot to add a Signed-off-by: line for every patch, as per > Documentation/SubmittingPatches. Care to redo them? Here it is (I'm sorry about that). Use i2c_transfer to send message, so we get proper bus locking. Signed-off-by: Ladislav Michl <ladis at linux-mips.org> ===== drivers/i2c/chips/ds1337.c 1.1 vs edited ===== --- 1.1/drivers/i2c/chips/ds1337.c 2005-03-31 22:58:08 +02:00 +++ edited/drivers/i2c/chips/ds1337.c 2005-04-08 00:18:45 +02:00 @@ -3,7 +3,7 @@ * * Copyright (C) 2005 James Chapman <jchapman at katalix.com> * - * based on linux/drivers/acron/char/pcf8583.c + * based on linux/drivers/acorn/char/pcf8583.c * Copyright (C) 2000 Russell King * * This program is free software; you can redistribute it and/or modify @@ -119,8 +119,7 @@ msg[1].len = sizeof(buf); msg[1].buf = &buf[0]; - result = client->adapter->algo->master_xfer(client->adapter, - &msg[0], 2); + result = i2c_transfer(client->adapter, msg, 2); dev_dbg(&client->adapter->dev, "%s: [%d] %02x %02x %02x %02x %02x %02x %02x\n", @@ -194,8 +193,7 @@ msg[0].len = sizeof(buf); msg[0].buf = &buf[0]; - result = client->adapter->algo->master_xfer(client->adapter, - &msg[0], 1); + result = i2c_transfer(client->adapter, msg, 1); if (result < 0) { dev_err(&client->adapter->dev, "ds1337[%d]: error " "writing data! %d\n", data->id, result);